New Scheduler merged into r8442M

After you have edited the source code, post your patch here.
Forum rules
Home | Wiki | Rules

Re: New Scheduler merged into r8442M

Postby mojo85 » 25 Mar 2010 01:57

I've tested this latest code so far, and things run smooth. I think it is ready to commit as well. Time to implement this change that has taken more than 4 years in the making. It is a lot more stable and reliable than the state I recovered the code.
mojo85
 
Posts: 115
Joined: 27 Sep 2009 05:35

Re: New Scheduler merged into r8442M

Postby old_death » 28 Mar 2010 13:49

User avatar
old_death
 
Posts: 1950
Joined: 13 Jun 2009 16:19

Re: New Scheduler merged into r8442M

Postby cyko_01 » 28 Mar 2010 16:31

I have tried to commit it myself, but every time I do I find he has changed the files I am trying to update. I do not want to create any bugs or regressions, and I do not want him to revert my commit either. He has not committed anything in the last few days so if you can provide me with a clean patch for rev.8530 then I will try again. Be sure to remove any of your personal build settings as well (not done with previous 8522 patch) and compare your files with the ones on SVN using a program like winmerge
User avatar
cyko_01
 
Posts: 938
Joined: 13 Jun 2009 15:51

V81 into r8530

Postby siavoshkc » 28 Mar 2010 22:12

Resource files were nightmare.
Attachments
Scheduler merged into r8530 plus media player keeps track of 3 players [V81][siavoshkc].zip
(242.46 KiB) Downloaded 114 times
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: New Scheduler merged into r8442M

Postby cyko_01 » 28 Mar 2010 23:53

ok, the hard part is finally done. It has been committed as rev. 8531 . It should be included in the next daily build.
User avatar
cyko_01
 
Posts: 938
Joined: 13 Jun 2009 15:51

Re: New Scheduler merged into r8442M

Postby kevogod » 29 Mar 2010 03:39

kevogod
 
Posts: 278
Joined: 13 Jun 2009 16:13

Re: New Scheduler merged into r8442M

Postby siavoshkc » 29 Mar 2010 12:40

Please change OnTimer(UINT) to OnTimer(UINT_PTR) in:
WndScheduler.cpp (Definition)
WndScheduler.h (Declaration)

Thank You
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: New Scheduler merged into r8442M

Postby cyko_01 » 29 Mar 2010 12:51

User avatar
cyko_01
 
Posts: 938
Joined: 13 Jun 2009 15:51

Re: New Scheduler merged into r8442M

Postby siavoshkc » 29 Mar 2010 14:47

I just noticed that Scheduler.h is included twice in Scheduler.cpp
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: New Scheduler merged into r8442M

Postby mojo85 » 29 Mar 2010 19:22

mojo85
 
Posts: 115
Joined: 27 Sep 2009 05:35

Re: New Scheduler merged into r8442M

Postby cyko_01 » 29 Mar 2010 22:31

User avatar
cyko_01
 
Posts: 938
Joined: 13 Jun 2009 15:51

Re: New Scheduler merged into r8442M

Postby kevogod » 29 Mar 2010 23:56

Please compile it before you commit code.

Linking...
Scheduler.obj : error LNK2019: unresolved external symbol RasGetConnectStatusW referenced in function "public: void __cdecl CScheduler::HangUpConnection(void)" (?HangUpConnection@CScheduler@@QEAAXXZ)
Scheduler.obj : error LNK2019: unresolved external symbol RasHangUpW referenced in function "public: void __cdecl CScheduler::HangUpConnection(void)" (?HangUpConnection@CScheduler@@QEAAXXZ)
Scheduler.obj : error LNK2019: unresolved external symbol RasEnumConnectionsW referenced in function "public: void __cdecl CScheduler::HangUpConnection(void)" (?HangUpConnection@CScheduler@@QEAAXXZ)
x64\Debug\Shareaza.exe : fatal error LNK1120: 3 unresolved externals
kevogod
 
Posts: 278
Joined: 13 Jun 2009 16:13

Re: New Scheduler merged into r8442M

Postby siavoshkc » 30 Mar 2010 08:45

rasapi32.lib should be set as linker input in x64 configuration.
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: New Scheduler merged into r8442M

Postby kevogod » 30 Mar 2010 23:47

kevogod
 
Posts: 278
Joined: 13 Jun 2009 16:13

v81

Postby siavoshkc » 31 Mar 2010 05:15

Attachments
vcproj9 of v81_CtrlUploads.zip
(14.53 KiB) Downloaded 96 times
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: New Scheduler merged into r8442M

Postby kevogod » 01 Apr 2010 03:12

Shareaza crashes when you right-click > "Add Scheduled Task".
kevogod
 
Posts: 278
Joined: 13 Jun 2009 16:13

Re: New Scheduler merged into r8442M

Postby old_death » 01 Apr 2010 10:09

User avatar
old_death
 
Posts: 1950
Joined: 13 Jun 2009 16:19

Scheduler merged into r8534M

Postby siavoshkc » 01 Apr 2010 10:33

siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: New Scheduler merged into r8442M

Postby kevogod » 02 Apr 2010 00:51

Last edited by kevogod on 25 Apr 2010 07:13, edited 1 time in total.
Reason: Removed negatis link
kevogod
 
Posts: 278
Joined: 13 Jun 2009 16:13

Scheduler merged into r8534M (EDITED)

Postby siavoshkc » 02 Apr 2010 10:03

x64 does not compile because my last post is not commited. Please commit that and this one together with comment "Adding rasapi32.lib to x64 project configuraion; Correcting typo in comments and bug in DlgScheduleTask.cpp".

[EDIT] I changed file because I detected a bug

[EDIT] Thanks kevgod

Thanks for your care
Attachments
DlgScheduleTask.cpp
(14.93 KiB) Downloaded 107 times
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: New Scheduler merged into r8442M

Postby siavoshkc » 02 Apr 2010 20:38

Note the edit in my las post please.
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: New Scheduler merged into r8442M

Postby mojo85 » 03 Apr 2010 22:14

So any update, can these further commits be added. Should get a binary to spit out to test for the masses.
mojo85
 
Posts: 115
Joined: 27 Sep 2009 05:35

Re: New Scheduler merged into r8442M

Postby cyko_01 » 04 Apr 2010 00:52

User avatar
cyko_01
 
Posts: 938
Joined: 13 Jun 2009 15:51

Re: New Scheduler merged into r8442M

Postby siavoshkc » 04 Apr 2010 11:44

siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: New Scheduler merged into r8442M

Postby cyko_01 » 04 Apr 2010 14:26

done! committed as rev.8635
User avatar
cyko_01
 
Posts: 938
Joined: 13 Jun 2009 15:51

Re: New Scheduler merged into r8442M

Postby kevogod » 04 Apr 2010 22:20

kevogod
 
Posts: 278
Joined: 13 Jun 2009 16:13

Re: New Scheduler merged into r8442M

Postby kevogod » 05 Apr 2010 00:57

I have updated the Tango skin for the latest revision: http://shareaza.negatis.com/unofficial/ ... evogod.zip

Unfortunately, due to Shareaza 2.5.2.0's strict handling of skin files, it will not work correctly with 2.5.2.0.
kevogod
 
Posts: 278
Joined: 13 Jun 2009 16:13

Re: New Scheduler merged into r8442M

Postby cyko_01 » 05 Apr 2010 01:55

User avatar
cyko_01
 
Posts: 938
Joined: 13 Jun 2009 15:51

Re: New Scheduler merged into r8442M

Postby raspopov » 09 Apr 2010 15:51

1. Fix not working "Activate schedule" checkbox in dialog.
2. Fix AfxMessageBox( _T("Error") ); replacing by some reliable message.
3. Fix dialog and new string translation i.e. in default-en.xml.
4. Remove extra "X.ico" we already have "X"-shaped bitmap.
5. Remove extra source files.
User avatar
raspopov
Project Admin
 
Posts: 945
Joined: 13 Jun 2009 12:30

Re: New Scheduler merged into r8442M

Postby siavoshkc » 13 Apr 2010 11:12

siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: New Scheduler merged into r8442M

Postby raspopov » 13 Apr 2010 15:41

Translation.
User avatar
raspopov
Project Admin
 
Posts: 945
Joined: 13 Jun 2009 12:30

Re: New Scheduler merged into r8442M

Postby siavoshkc » 13 Apr 2010 17:54

siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: New Scheduler merged into r8442M

Postby ocexyz » 13 Apr 2010 19:41

User avatar
ocexyz
 
Posts: 624
Joined: 15 Jun 2009 13:09

Re: New Scheduler merged into r8442M

Postby raspopov » 14 Apr 2010 03:34

Your changes are not translatable. So add translation support for dialog and all strings.
User avatar
raspopov
Project Admin
 
Posts: 945
Joined: 13 Jun 2009 12:30

Re: New Scheduler merged into r8442M

Postby siavoshkc » 14 Apr 2010 18:20

How should I test my translation?

[edit]
I can copy paste from default.xml to default-en.xml ecept for the string part at the tail. What should I do for that?
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: New Scheduler merged into r8442M

Postby raspopov » 14 Apr 2010 19:09

Don't forget dialog translation.
User avatar
raspopov
Project Admin
 
Posts: 945
Joined: 13 Jun 2009 12:30

r8557 U2

Postby siavoshkc » 15 Apr 2010 16:49

Please check this out and inform me on shortcomings if any.

[EDIT]
Some functions inlined.

[EDIT2]
Some major changes are needed in Scheduler system. Attachment deleted.
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

v9

Postby siavoshkc » 20 Apr 2010 13:40

Please commite this ASAP. Thank you.


[ATTACHMENT EDITED]
Attachments
Scheduler [v9] merged into r8576.7z
(151.68 KiB) Downloaded 99 times
Last edited by siavoshkc on 22 Apr 2010 14:41, edited 1 time in total.
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: v9

Postby cyko_01 » 20 Apr 2010 23:53

User avatar
cyko_01
 
Posts: 938
Joined: 13 Jun 2009 15:51

Re: New Scheduler merged into r8442M

Postby siavoshkc » 22 Apr 2010 14:44

I named file incorrectly. Please commit.
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

PreviousNext

Return to Code Submission

Who is online

Users browsing this forum: No registered users and 1 guest