Media Setting page can keep track of 3 external players

After you have edited the source code, post your patch here.
Forum rules
Home | Wiki | Rules

Media Setting page can keep track of 3 external players

Postby siavoshkc » 25 Jan 2010 21:00

It was one of my feature requests once. Now I have implemented it.
Before this when you switched back to Shareaza Media Player the other player was deleted.
Attachments
r8442 to keep track of 3 external media players.zip
(87.71 KiB) Downloaded 76 times
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: Media Setting page can keep track of 3 external players

Postby old_death » 25 Jan 2010 22:01

Cool, I requested this feature some time ago, too. Hopefully, it gets committed AFAP.
User avatar
old_death
 
Posts: 1950
Joined: 13 Jun 2009 16:19

Re: Media Setting page can keep track of 3 external players

Postby siavoshkc » 27 Jan 2010 17:33

Bug: Order of players was changed each time setting page was opened.->FIXED
Attachments
r8442 to keep track of 3 external media players v2.rar
(1.06 KiB) Downloaded 75 times
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: Media Setting page can keep track of 3 external players

Postby siavoshkc » 29 Jan 2010 21:17

Two bugs fixed.
Attachments
FileExecutor.cpp
(26.32 KiB) Downloaded 73 times
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: Media Setting page can keep track of 3 external players

Postby raspopov » 01 Feb 2010 20:34

Good work, but...
1. Please don't post multiply files, update only one zip-file.
2. What about changed CSettings::sScheduler member in your version of Settings.h? Is it from different patch? Please provide "clean" patches only.
3. How about replacing non-standard CString[3] by standard string_set class and removing extra ServiceIndex option?
User avatar
raspopov
Project Admin
 
Posts: 945
Joined: 13 Jun 2009 12:30

Re: Media Setting page can keep track of 3 external players

Postby siavoshkc » 04 Feb 2010 12:17

siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: Media Setting page can keep track of 3 external players

Postby raspopov » 04 Feb 2010 16:04

Other interface elements already used string_set, just copy code from there.
User avatar
raspopov
Project Admin
 
Posts: 945
Joined: 13 Jun 2009 12:30

Re: Media Setting page can keep track of 3 external players

Postby siavoshkc » 05 Feb 2010 21:34

siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: Media Setting page can keep track of 3 external players

Postby raspopov » 06 Feb 2010 09:29

The main idea is to use the most standard types (already used types) to implement in the future universal way of options editing at advanced settings dialog, so try to use DWORD, bool, DOUBLE, CString and string_set only. Btw its pretty simple task, for example you can add some special symbol at string_set's string start to mark it as "selected" i.e. "mpc.exe|*lightalllow.exe|wplayer.exe". You are developer you must think! :geek:
User avatar
raspopov
Project Admin
 
Posts: 945
Joined: 13 Jun 2009 12:30

Re: Media Setting page can keep track of 3 external players

Postby siavoshkc » 09 Feb 2010 18:52

siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37


Return to Code Submission

Who is online

Users browsing this forum: No registered users and 1 guest

cron