Scheduler Validity Period

After you have edited the source code, post your patch here.
Forum rules
Home | Wiki | Rules

Scheduler Validity Period

Postby siavoshkc » 01 Aug 2010 11:09

There was a problem:
You had set a task to be executed in 6:30 am, Shut Down PC for example on everyday. When you run Shareaza at 7 pm next day surprisingly PC counts down for Shutdown. This is because its passed 6:30 and download is for every day so shutdown task has to be executed.

The solution is to set a validity period for each task. For example when I set validity period for shut down task, say 5 minutes, shut down task is only valid until 6:35. After that it won't be executed for that day.

Versioning for XML export is also added.

Patch is update. Please commit ASAP.
Attachments
Scheduler_ValidityPeriod.7z
(91.28 KiB) Downloaded 87 times
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: Scheduler Validity Period

Postby old_death » 05 Aug 2010 15:09

That's nice. Will that also make it possible to use the validity period to make Shareaza limit the used bandwidth, even if the PC is turned on after the rule execution started?
User avatar
old_death
 
Posts: 1950
Joined: 13 Jun 2009 16:19

Re: Scheduler Validity Period

Postby siavoshkc » 09 Aug 2010 12:09

siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: Scheduler Validity Period

Postby ailurophobe » 11 Aug 2010 22:56

Not much else has been committed either so reasonable guess would be the devs are busy with RL.
ailurophobe
 
Posts: 709
Joined: 11 Nov 2009 05:25

Re: Scheduler Validity Period

Postby old_death » 14 Aug 2010 15:03

Yeah, there hasn't been posted code for almost two weeks before Ryo posted his code updates yesterday... I suppose he'll commit it once he had a look at this forum...
User avatar
old_death
 
Posts: 1950
Joined: 13 Jun 2009 16:19

Re: Scheduler Validity Period

Postby siavoshkc » 15 Aug 2010 09:49

Delaying commit delays alpha tests. Also keeps my local repository in modified state which I hate.
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: Scheduler Validity Period

Postby cyko_01 » 15 Aug 2010 18:58

why was the entire designinfo section removed from shareaza.rc ? looks good other then that
User avatar
cyko_01
 
Posts: 938
Joined: 13 Jun 2009 15:51

Re: Scheduler Validity Period

Postby siavoshkc » 19 Aug 2010 13:06

Attachments
Scheduler_ValidityPeriod[2].7z
(92.25 KiB) Downloaded 97 times
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: Scheduler Validity Period

Postby cyko_01 » 19 Aug 2010 23:41

committed as rev 8716
User avatar
cyko_01
 
Posts: 938
Joined: 13 Jun 2009 15:51

Re: Scheduler Validity Period

Postby old_death » 25 Aug 2010 15:13

Seems that Ryo reverted this commit because it broke compilation...
User avatar
old_death
 
Posts: 1950
Joined: 13 Jun 2009 16:19

Re: Scheduler Validity Period

Postby cyko_01 » 26 Aug 2010 03:02

User avatar
cyko_01
 
Posts: 938
Joined: 13 Jun 2009 15:51

Re: Scheduler Validity Period

Postby ailurophobe » 26 Aug 2010 21:12

You were not accused of anything that I noticed... But sure, now that ryo is around, he can do the commit once siavohkc figures out what went wrong. Something in Shareaza.rc maybe? That seems to be the only file your commit and the DC++ commit ryo did just before have in common and messing it up would "break compilation", I guess.
ailurophobe
 
Posts: 709
Joined: 11 Nov 2009 05:25

Re: Scheduler Validity Period

Postby kevogod » 27 Aug 2010 00:33

kevogod
 
Posts: 278
Joined: 13 Jun 2009 16:13

Re: Scheduler Validity Period

Postby siavoshkc » 01 Sep 2010 12:42

Of course I tested the code before placing it here it compiled and worked fine.

I updated to r8743 my local code and still everything is fine. Compiles and runs smoothly. Which means I have a running Shareaza with Validity Period while others don't. :idea:

Maybe the problem was with the package commited or Ryo changing icons.

Anyway here is another patch in r8743.
Attachments
vp3 [r8743].7z
(10.69 KiB) Downloaded 86 times
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: Scheduler Validity Period

Postby raspopov » 02 Sep 2010 20:00

I hate diffs. 8-) Please post complete files.
User avatar
raspopov
Project Admin
 
Posts: 945
Joined: 13 Jun 2009 12:30

Re: Scheduler Validity Period

Postby siavoshkc » 05 Sep 2010 05:14

Here we go...
Attachments
SchedulerValidityPeriod.7z
(92.3 KiB) Downloaded 69 times
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: Scheduler Validity Period

Postby raspopov » 05 Sep 2010 07:28

Committed but... Task dialog is very ugly. Can you follow MS GUI design guidelines?
User avatar
raspopov
Project Admin
 
Posts: 945
Joined: 13 Jun 2009 12:30


Return to Code Submission

Who is online

Users browsing this forum: No registered users and 1 guest

cron