Schedule Task Dlg Rearrangement

After you have edited the source code, post your patch here.
Forum rules
Home | Wiki | Rules

Schedule Task Dlg Rearrangement

Postby siavoshkc » 17 Sep 2010 18:41

Talking with old_death and using his recommandation we rearanged this dialog and I think this one is much better.
Attachments
Shareaza SchTaskDlg Rearrangement.7z
(68.96 KiB) Downloaded 142 times
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: Schedule Task Dlg Rearrangement

Postby kevogod » 17 Sep 2010 23:51

Please provide a screenshot for reference.
kevogod
 
Posts: 278
Joined: 13 Jun 2009 16:13

Re: Schedule Task Dlg Rearrangement

Postby siavoshkc » 25 Sep 2010 06:12

Screen shot
SchDlg.JPG
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: Schedule Task Dlg Rearrangement

Postby cyko_01 » 25 Sep 2010 14:59

This dialog still looks very disorganized to me. I still prefer this one.....but of course that one is much more work to implement :P
User avatar
cyko_01
 
Posts: 938
Joined: 13 Jun 2009 15:51

Re: Schedule Task Dlg Rearrangement

Postby old_death » 26 Sep 2010 19:50

Nice work, Sia!

@ Cyko, your design idea lacks some of the features offered by this version of the dialog. You might want to create a new revision of it...? Because the general look'n feel of your dialog seems good to me, however, if it offers less functionality, it is unlikely to be chosen for implementation.

However, sias dialog currently lacks the possibilities to use intervals (except for 1 week intervals), so you can't do something every 13 days for example... Even if this is not very important for most users...
User avatar
old_death
 
Posts: 1950
Joined: 13 Jun 2009 16:19

Re: Schedule Task Dlg Rearrangement

Postby cyko_01 » 26 Sep 2010 23:42

see my reply here
User avatar
cyko_01
 
Posts: 938
Joined: 13 Jun 2009 15:51

Re: Schedule Task Dlg Rearrangement

Postby siavoshkc » 13 Oct 2010 07:24

Is anyone going to commit this?
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: Schedule Task Dlg Rearrangement

Postby raspopov » 18 Oct 2010 16:04

Several labes not fit even in english language:
bugs.gif



I think we must remove custom scheduler code and use Windows Task Scheduler API 1.0 (or 2.0 on Vista and above).
User avatar
raspopov
Project Admin
 
Posts: 945
Joined: 13 Jun 2009 12:30

Re: Schedule Task Dlg Rearrangement

Postby old_death » 18 Oct 2010 22:08

User avatar
old_death
 
Posts: 1950
Joined: 13 Jun 2009 16:19

Re: Schedule Task Dlg Rearrangement

Postby raspopov » 19 Oct 2010 03:39

Why you don't think so?
User avatar
raspopov
Project Admin
 
Posts: 945
Joined: 13 Jun 2009 12:30

Re: Schedule Task Dlg Rearrangement

Postby ailurophobe » 19 Oct 2010 05:05

I believe the task scheduler API is supported by Windows PowerShell and third party automation programs. (Please correct if I am wrong.) That would make it possible to script or automate arbitrarily complex behaviours for Shareaza using any tool you happen to prefer. And the API itself is pretty powerful to begin with.

Not sure if it is a must, but it would be more powerful than any custom solution we can make. And Microsoft would take care of bug fixes...
ailurophobe
 
Posts: 709
Joined: 11 Nov 2009 05:25

Re: Schedule Task Dlg Rearrangement

Postby siavoshkc » 19 Oct 2010 13:58

I had the idea of using Windows facilities from the beginning. But preferred not to use it for the reasons I don't remember. :D

I think we should make current one usable for the next release and we will have time to implement a better one. What I do know is that I am not the one who will implement it as I like to be involved in network core and system parts. But i will continue supporting current Scheduler.

BTW, how should I know how long should my text boxes be?
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: Schedule Task Dlg Rearrangement

Postby raspopov » 19 Oct 2010 15:00

Please wait, I seriously researching possibility of Windows Task Scheduler implementation in Shareaza.
User avatar
raspopov
Project Admin
 
Posts: 945
Joined: 13 Jun 2009 12:30

Re: Schedule Task Dlg Rearrangement

Postby siavoshkc » 20 Oct 2010 16:46

I think you should really stop adding features before fixing old bugs. Not only fixing detected bugs but devs should also throughly test debug builds to find not detected/reported bugs. Developers are also best testers as they know potentially buggy spots and dangerous scenarios.

There are still many minor bugs that some of them are fatal hanging around.
siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: Schedule Task Dlg Rearrangement

Postby raspopov » 20 Oct 2010 16:56

Fixing Scheduler is a bug fixing.
User avatar
raspopov
Project Admin
 
Posts: 945
Joined: 13 Jun 2009 12:30

Re: Schedule Task Dlg Rearrangement

Postby ailurophobe » 20 Oct 2010 17:15

He is not really talking about adding new features as much as moving some of the current features to use a service Microsoft supports and debugs.
ailurophobe
 
Posts: 709
Joined: 11 Nov 2009 05:25

Re: Schedule Task Dlg Rearrangement

Postby old_death » 20 Oct 2010 17:26

User avatar
old_death
 
Posts: 1950
Joined: 13 Jun 2009 16:19

Re: Schedule Task Dlg Rearrangement

Postby cyko_01 » 20 Oct 2010 22:22

User avatar
cyko_01
 
Posts: 938
Joined: 13 Jun 2009 15:51

Re: Schedule Task Dlg Rearrangement

Postby siavoshkc » 21 Oct 2010 18:00

siavoshkc
 
Posts: 347
Joined: 02 Nov 2009 09:37

Re: Schedule Task Dlg Rearrangement

Postby raspopov » 21 Oct 2010 20:09

Almost done...
User avatar
raspopov
Project Admin
 
Posts: 945
Joined: 13 Jun 2009 12:30

Re: Schedule Task Dlg Rearrangement

Postby old_death » 21 Oct 2010 20:33

Nice! :mrgreen:
User avatar
old_death
 
Posts: 1950
Joined: 13 Jun 2009 16:19

Re: Schedule Task Dlg Rearrangement

Postby raspopov » 26 Oct 2010 18:47

Please test new scheduler.
User avatar
raspopov
Project Admin
 
Posts: 945
Joined: 13 Jun 2009 12:30


Return to Code Submission

Who is online

Users browsing this forum: No registered users and 1 guest