Invalid uptime reported

Post comments about Shareaza code and discuss with other developers.
Forum rules
Home | Wiki | Rules

Invalid uptime reported

Postby ale5000 » 10 Jan 2016 06:34

The spec say the maximum value for uptime is 31536000 but I see Shareaza 2.7.9.0 reporting higher values and also it report repetitively the same GWC.

Example query:
Code: Select all
?ip=__.__.__.__:6346&x.leaves=141&uptime=1135680326&x.max=300&url=http%3A%2F%2Fgweb.4octets.co.uk%2Fskulls.php&update=1&net=gnutella2&client=RAZA2.7.9.0


Since I doubt this client is opened from 36 years there must be some bug calculating seconds.
ale5000
 
Posts: 66
Joined: 18 Nov 2012 22:56

Re: Invalid uptime reported

Postby raspopov » 10 Jan 2016 06:42

Looks like DWORD with time was wrapped. In many places Shareaza still using DWORD (32-bit) for time measuring and it's start shows wrong values after 49.7 day from Windows start (it can be on servers and never-rebooted notebooks).
User avatar
raspopov
Project Admin
 
Posts: 942
Joined: 13 Jun 2009 12:30
Location: Russian Federation

Re: Invalid uptime reported

Postby ale5000 » 10 Jan 2016 06:48

And about reporting repetitively the same GWC 15 times?
It shouldn't re-report the same GWC every time if the previous reporting is failed, it should be random every time.
ale5000
 
Posts: 66
Joined: 18 Nov 2012 22:56

Re: Invalid uptime reported

Postby raspopov » 10 Jan 2016 06:57

Exactly, with wrapped time Shareaza always think "I reported to this GWC too long ago, need update."
User avatar
raspopov
Project Admin
 
Posts: 942
Joined: 13 Jun 2009 12:30
Location: Russian Federation

Re: Invalid uptime reported

Postby ale5000 » 10 Jan 2016 07:02

But Shareaza shouldn't just report the one reported earliest in the past, but a random one from the list of reported earlier; this is safer in every case.
ale5000
 
Posts: 66
Joined: 18 Nov 2012 22:56

Re: Invalid uptime reported

Postby raspopov » 10 Jan 2016 07:04

It's just an assumption.
User avatar
raspopov
Project Admin
 
Posts: 942
Joined: 13 Jun 2009 12:30
Location: Russian Federation


Return to Development Discussion

Who is online

Users browsing this forum: No registered users and 1 guest