Buggy 404

[blackflag100]

But maybe not in r8848.

Symptom: search turns up a file X with a single, complete source. I double click it. It appears in Transfers with 1 source, Queued. I hit Resume, it goes bold almost right away, then Searching (No Sources).

Network tab shows 404 message from the file's source right when that happened.

OK, maybe not a bug, maybe the guy deleted the file in between his client sending the query hit and me double-clicking it.

New search -- same terms -- same file quickly shows up, with the same single source.

Repeat a couple more times just to be sure.



Either the other guy is deleting and undeleting the file with perfect bad timing, or (much more likely) either his client or mine has a bug that is causing a file to be treated as shared for the purpose of generating query hits, but not shared for the purpose of actually transferring chunks.

However, the other guy's client identifies itself as "Shareaza" (no version number, oddly), so it looks like either way this one's yours.

[old_death]

There is a bug within the Shareaza library code: If there are several copies of one file, and one of them is unshared, the file is returned as a search result, however, if someone actually tries to request parts of that file, a 404 error is returned.

I've added this as Ticket #148 to the tracker.

[blackflag100]

[raspopov]

It's a feature, not a bug.

[old_death]

No, it is definitively a bug: Either, there should be no hit returned to searching clients, or the file should be uploaded if requested.

Allowing to find it and afterwards not allowing to download it is just useless.

[old_death]

[raspopov]

All files are hashed and Shareaza serves incoming clients by hash only so it can found unshared file with corresponding hash first and report 404.

[old_death]

... which is a bug and needs to be fixed. As long as there is one shared copy of a file in the Shareaza library, every G2 user should be able to download that file, no matter how many copies of that file do exist that are currently unshared.

[raspopov]

You don't understand, there are two files: first has DISABLED sharing and second has enabled. Which one Shareaza must offer? What user want? To be or not to be...

[old_death]

Shareaza must offer the shared one, always. Everything else does not make sense for users: If a file is returned as a search result, it must be downloadable.

[raspopov]

[old_death]

True, however Shareaza should always return the most usable result, which is per definition a downloadable file, isn't it?