Page 1 of 1

Media Setting page can keep track of 3 external players

PostPosted: 25 Jan 2010 21:00
by siavoshkc
It was one of my feature requests once. Now I have implemented it.
Before this when you switched back to Shareaza Media Player the other player was deleted.

Re: Media Setting page can keep track of 3 external players

PostPosted: 25 Jan 2010 22:01
by old_death
Cool, I requested this feature some time ago, too. Hopefully, it gets committed AFAP.

Re: Media Setting page can keep track of 3 external players

PostPosted: 27 Jan 2010 17:33
by siavoshkc
Bug: Order of players was changed each time setting page was opened.->FIXED

Re: Media Setting page can keep track of 3 external players

PostPosted: 29 Jan 2010 21:17
by siavoshkc
Two bugs fixed.

Re: Media Setting page can keep track of 3 external players

PostPosted: 01 Feb 2010 20:34
by raspopov
Good work, but...
1. Please don't post multiply files, update only one zip-file.
2. What about changed CSettings::sScheduler member in your version of Settings.h? Is it from different patch? Please provide "clean" patches only.
3. How about replacing non-standard CString[3] by standard string_set class and removing extra ServiceIndex option?

Re: Media Setting page can keep track of 3 external players

PostPosted: 04 Feb 2010 12:17
by siavoshkc

Re: Media Setting page can keep track of 3 external players

PostPosted: 04 Feb 2010 16:04
by raspopov
Other interface elements already used string_set, just copy code from there.

Re: Media Setting page can keep track of 3 external players

PostPosted: 05 Feb 2010 21:34
by siavoshkc

Re: Media Setting page can keep track of 3 external players

PostPosted: 06 Feb 2010 09:29
by raspopov
The main idea is to use the most standard types (already used types) to implement in the future universal way of options editing at advanced settings dialog, so try to use DWORD, bool, DOUBLE, CString and string_set only. Btw its pretty simple task, for example you can add some special symbol at string_set's string start to mark it as "selected" i.e. "mpc.exe|*lightalllow.exe|wplayer.exe". You are developer you must think! :geek:

Re: Media Setting page can keep track of 3 external players

PostPosted: 09 Feb 2010 18:52
by siavoshkc