Page 1 of 1

2.5 bug: silently overwrites files

PostPosted: 11 Jan 2010 20:13
by grey-hame
If you download two files with the same name, previous versions of Shareaza gave one a numbered appendix to the file name; e.g. if you downloaded two files named "xyz.jpg" you'd get one "xyz.jpg" and the second would save as "xyz (2).jpg" or similarly.

2.5 seems to just overwrite: I downloaded two same-named files and found only one file after the downloads were complete. Then I did something similar again, only this time as soon as one file had downloaded I opened it in something so the file would be in use when the other one completed. Tellingly, that one wound up with the "File Error" status.

This needs to be changed back to the old behavior in 2.5.2.0; it was observed in 2.5.1.0.

Re: 2.5 bug: silently overwrites files

PostPosted: 11 Jan 2010 21:26
by ailurophobe
Actually, I guess the renaming was done by Windows instead of Shareaza, and the way the file is moved to Downloads folder was changed to form where Windows no longer takes care of it for us. It might be better to add code that prompts for new name when two files have identical names when the download is started instead of restoring the old Windows standard approach of invisibly adding a number tag to the name. If you can confirm this happens always you should probably report it as a bug.

Re: 2.5 bug: silently overwrites files

PostPosted: 12 Jan 2010 17:32
by grey-hame

Re: 2.5 bug: silently overwrites files

PostPosted: 14 Jan 2010 04:33
by e144539
Maybe ailurophobe meant report a bug to the seldom used bug tracker here:
https://sourceforge.net/apps/trac/shareaza/newticket
You will need to make a sourceforge account if you don't have one already.

Reading the "Reporting Bugs guide" first is a good idea.
https://sourceforge.net/apps/trac/share ... ing%20Bugs

Re: 2.5 bug: silently overwrites files

PostPosted: 14 Jan 2010 15:33
by old_death
Reporting the bug in the forums is not what we call reporting a bug. Plz use the bug tracker (link can be found in the wiki and on the debug builds download page) if you would like to make a formal bug report.

EDIT: Well, and the link can also be found in the previous post... ;)

Re: 2.5 bug: silently overwrites files

PostPosted: 03 Jun 2012 14:18
by cyko_01
I hate to bump an old thread, but it seems like this has FINALLY been fixed in rev.9159. Since this bit of code is currently being worked on, now is your best chance to have it fixed if it is still not working.

Please test!