"Browse User" logic inverted

[casadelgato]

After the upgrade to 2.5.0.0 I've noticed that the logic to enable the right-click popup menu item "Browse User" is inverted for the Downloads list.
It's enabled for eDonkey users, and disabled for (darn, forgot the name - blue circle with white H) users.
On the Uploads list, it's correct.

[ocexyz]

Thx. please delivere more details: what is your system?

[casadelgato]

Win XP Pro, 3GB RAM, AMD Quad Core, Gobs and Gobs of HD space.
DSL network connection, 256/768.

[raspopov]

"Browse" works on per-host basis, if remote application supports browse requests (ED2K or G1/G2) by setting special flags in incoming packets then your Shareaza enable "Browse" menu item for this host. Since 2.5.0.0 Shareaza can browse ED2K-clients, but eMule has this ability turned off by default, so its pretty rare to catch browsable eMule.

[ocexyz]

[raspopov]

[ocexyz]

[ailurophobe]

Actually, graying is the correct established way to show that some option is disabled for a particular item. It is quite literally the way it is supposed to be done. A more informative text is a good idea in theory, but context menu items are supposed to be short and refer to actions. General information like whether the client supports browse belong to other parts of the UI. You could add it to something that comes up on hover or a proper client details dialogue window.

[ocexyz]

[ailurophobe]

I agree a better explanation should be offered, I just don't think the context menu is the right place to put it.

[casadelgato]

Okay, so it's working as designed.
The only real problem I had is that it was DIFFERENT from the way it used to work.
It used to always be enabled for one set of host types (even if they had browsing disabled), and disabled for all others.
Now it appears that it's enabled for any host type IF some flag is set in one of the packets received from them?
So, it's more specific now, you don't get an Enabled Browse even if the specific host doesn't allow browsing.
Correct?

[old_death]

There is a little description on the left side on the bottom of the Shareaza window. This item should change appropriately. (For browse user this is: "Browses the selected user's profile and shared files")

EDIT: It should be possible adding bold and italic text to these descriptions. Then adding a '(disabled)' in bold text style to the description would be better visible.

[ailurophobe]

"Browses the selected user's profile and shared files unless they have disabled it." Something like that?

[old_death]

[ocexyz]

Well, in general this means dear dev most ppl agree additional info is welcome, helpful or just needed.

[ailurophobe]

[old_death]

True, but this wouldn't be as clear as the other possibility...