Shareaza

by **siavoshkc** » 23 Jan 2010 18:58

SYSTEMTIME is replaced by CTime.
Accelerator is added.

by **mojo85** » 24 Jan 2010 06:09

What do you mean by accelerator is added?

I have played with this, and it functions well. In any case I think it is about time we add it, and transform the GUI as we go. Also for the life of me I could not remove the Scheduler link in the Internet option of the settings window.

Also in the way I set it up in my transferring the code over, I didn't do an effective set of options. Bandwidth Stop is pretty much behaves like disconnect, if you have a dial-up it should disconnect the dial-up as well ... but what you observe is the rate monitor scale go to 0, and connections begin to disconnect. Bandwidth stop does the same thing, but it just doesn't initiate the dial-up to hang up. Also both actions disable all networks, I don't know if I did this, or it was by initial design ... I'm sure these are simple changes but those are areas for which I glossed over initially maybe siavoshkc you have ideas of different options worth adding or modifying ... these were mostly for testing/ sandbox what I did.

by **old_death** » 24 Jan 2010 15:45

by **siavoshkc** » 24 Jan 2010 16:34

by **cyko_01** » 24 Jan 2010 17:51

created task to shut down shareaza at specified time( a few minutes later) to run once. Restarted shareaza manually and edited task to run again in 2 minutes, reactivated. Crashes on startup while starting host cache.
BugTrap Log (buildV2)

by **cyko_01** » 24 Jan 2010 18:06

oh yea, and don't forget this feature:

by **siavoshkc** » 24 Jan 2010 23:35

by **siavoshkc** » 25 Jan 2010 09:06

Test this one.

I have a question about Locks. Why CSchedulerWnd::Update() uses CSingleLock pLock( &Network.m_pSection, TRUE ) ?

What will happen if it doesn't? It only reads Scheduler items (I didn't investigated it very well yet). Using lock in this way creates a potential danger because if another thread gets lock, scheduler window will freez so the main window.

by **mojo85** » 25 Jan 2010 11:49

This code was orginally done for implementation on Shareaza back in version 2.1 or maybe before? The code was lost, but at the time of writing technomage the original coder had adapted most of the code from the security window. In my edits, I removed plenty of "comments" referencing the Security Window ... not to worry as I just updated those references to mention Scheduler instead of erasing valuable commentary. In those days, Shareaza had many locks ... I think this has been reworked much better now. If you want to compare codes check out how the security window is coded as it should give insights as to what has changed from then to now.

by **siavoshkc** » 27 Jan 2010 17:48

[EDIT]v421 and v42 are bugee, deleted.
There is a bug that sometimes when SchedulerItemDlg is opened for edit right after task is done, hWnd assertions fail. I can't imagine why this happens because SchedulerItemDlg has nothing to do with WndScheduler or Scheduler code.

by **kevogod** » 28 Jan 2010 01:57

Just in case people do not see the updates to my post, you can download these builds from (link no longer available).

by **cyko_01** » 28 Jan 2010 02:29

by **siavoshkc** » 28 Jan 2010 13:16

I made limited networks and reduced bandwidth task depedent so they are not global anymore. This change affected settings.h and settings.cpp. The change I made for media palyer settings also adds some settings so I included related files in the patch.

-I disabled all locks (We may find places where its needed).
-Added strings for menu items to string resource
-Fixed a bug in CScheduleItemDlg that sometimes ignored date entered when you changed clock.
-Removed IsEnabled() and gave its job to CheckSchedule()
-CheckShedule() will be called in WndMain OnTimer() and OnCreate()

The bug in which ScheduleItemDlg hWnd becomes invalid still exists.

by **siavoshkc** » 28 Jan 2010 16:37

Bugtrap report of hWnd assertion failure in scheduler dialog.

by **kevogod** » 30 Jan 2010 17:31

I have uploaded the latest version.

by **siavoshkc** » 31 Jan 2010 06:30

Locks reimplemented.
Redundant field removed from DlgScheduleItem.

It was possible to make CScheduler thread safe if it didn't give pointer of internal fields to other objects. But now any object that gets these pointers should lock CScheduler::m_pSection before getting, setting or returning them.

by **siavoshkc** » 01 Feb 2010 21:13

Bug about being unable to save description in DlgScheduleItem->FIXED

by **siavoshkc** » 02 Feb 2010 11:17

Bug: Activate and Deactivate items in context menu of WndScheduler were not grayed out when no item was selected.->FIXED

I think this version except for hWnd assertion failure is a stable version ready to be merged into main code for a full scale test.

Thanks for your care.

by **mojo85** » 02 Feb 2010 18:44

Thanks for your time, dedication, and effort ... Ryo please add this finally. Actually one question, does this break x64 compilation?

by **cyko_01** » 04 Feb 2010 13:58

by **old_death** » 04 Feb 2010 14:39

by **siavoshkc** » 04 Feb 2010 19:45

by **ailurophobe** » 05 Feb 2010 11:36

RG: Assert before assignment?

by **siavoshkc** » 05 Feb 2010 21:15

by **siavoshkc** » 09 Feb 2010 18:38

I tried to make it like security module.

Note that the way Media Player List works is not approved by project admin. It's just needed for code to be compiled.

by **siavoshkc** » 10 Feb 2010 21:16

Media player setting problem solved.

[EDIT] There may be a misplacement of icons. Will be corrected in the next version.

by **siavoshkc** » 16 Feb 2010 12:57

Stablized and bug fixed.

by **siavoshkc** » 18 Feb 2010 19:12

Important bug in dlg.
Clean ups.

by **siavoshkc** » 27 Feb 2010 20:28

Import/export from/to XML is added into next version.
More strings are added into resources.

I am waiting for some feedback.

Note that there are many links to old website in source code.

by **old_death** » 28 Feb 2010 00:07

by **mojo85** » 05 Mar 2010 03:29

I have been testing version 73 for about a week. Things run smoothly, and no apparent hiccups. I think this is ready, can we begin to move it into the trunk? Ryo, it's time to merge it or give feedback as on where needs to improve before importing. I think it is ready, can we move this in, and remove the old ... this is a revamp that is more than 3 years in the making, it is about time.

by **cyko_01** » 06 Mar 2010 05:03

I was just comparing it with the code on SVN and I noticed a few small things that should be fixed.

1) some of the copyrights have been changed from 2010 back to 2009(and some are 2004 from original code submission).
2) you had moved some code around (optimized?)in the hub promotion section, but nothing missing as far as I could tell.
3) implemented nRating points awarded for not having a scheduled shutdown - good stuff
4) alpha/beta/release notice changed - oops! probably done for testing purposes
5) a few stray tabs - no biggie

You should make sure you sync it with the latest revision on SVN (rev. 8500) as well since new code has been added since (shareaza.cpp for one). It makes it a lot easier/faster when we do not have to merge old code with the new code before committing.

by **siavoshkc** » 07 Mar 2010 09:06

by **ocexyz** » 07 Mar 2010 14:26

Forgive me ignorance: where is actual ver for tests? I think in first post should be link to mosta actual one for testing - of course "on your own risk" etc.

by **cyko_01** » 07 Mar 2010 19:34

by **siavoshkc** » 09 Mar 2010 13:46

by **siavoshkc** » 17 Mar 2010 15:25

New functionality for selecting specific days of week is added. Please test it and commit if ready.

[EDIT]
There is also a little optimization in OnTimer() in CWndMain.

by **siavoshkc** » 24 Mar 2010 19:34

Has anybody tested the last version? When will be commited?

Shareaza

Who is online